fix(browser): align agent live-browser discovery timeouts#154
Merged
Conversation
- what: - raise browser status, profiles, and tabs client timeouts to the same 45s attach-discovery budget used by the CLI path. - add a client test that proves the longer timeout budget is applied to discovery calls. - why: - user-live attach through Chrome MCP can take tens of seconds, so the old 3s/10s/15s budgets made the agent path false-fail while raw browser CLI still worked. - risk: - browser discovery calls now wait longer before surfacing a real outage, which could slightly delay failure reporting for genuinely dead browser sessions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Fast Path
browser tabsstill works.browser --browser-profile user-live tabsreturned two livehttps://example.com/tabs and the exact agent smoke returnedTITLE: Example Domain.Why This Matters
user-liveattach can take tens of seconds when Chrome MCP is attaching or waiting on approval prompts.Scope Boundary
status,profiles, andtabsVerification
pnpm vitest --configLoader runner run src/browser/client.test.tsOPENCLAW_GATEWAY_PORT=18891 node dist/index.js browser --browser-profile user-live tabshttps://example.com/tabsOPENCLAW_GATEWAY_PORT=18891 node dist/index.js agent --agent main --session-id user-live-smoke --json --timeout 180 --message "In my Google Chrome browser, use my existing tab via the live browser and reply with exactly: TITLE: <page title>"TITLE: Example DomainAI Assistance