fix(nodes): fallback when runtimes omit system.run.prepare#319
Merged
artemgetmann merged 2 commits intoApr 4, 2026
Conversation
- what: add a shared local system.run approval-plan builder, use it across CLI and agent node exec paths, and update guidance/tests for direct safe-bin execution - why: live macOS nodes can advertise system.run without system.run.prepare, so hard-requiring prepare broke valid node shell execution and misled skills into treating runtime support as missing - risk: moderate; node exec approval metadata now has a local fallback path, so mismatches would affect approval/run binding across CLI and agent execution
- what: document the required -- separator when wrapping gog or himalaya through openclaw nodes run - why: live validation showed child flags get consumed by the wrapper CLI before they ever reach the safe bin - risk: low; guidance-only follow-up based on observed runtime behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review Fast Path
system.runbut omitssystem.run.prepare.pnpm vitest run src/cli/nodes-cli.coverage.test.ts src/agents/tools/nodes-tool.test.ts src/agents/bash-tools.exec.approval-id.test.tspassed (27/27),pnpm vitest run src/infra/system-run-approval-context.test.tspassed (10/10), and live JetBooknode scripts/run-node.mjs nodes run --node 'MacBook Pro (JetBook)' /bin/echo fallback-okprintedfallback-ok.system.run.prepareas a hard runtime incompatibility; they build the approval/run plan locally and keep approval binding metadata aligned.waclibinary (env: wacli: No such file or directory), andopenclaw nodes runstill needs--before child flags like--limitor--json.Why This Matters
system.runwithoutsystem.run.prepare.Scope Boundary
wacli,gog, andhimalaya.Verification
pnpm vitest run src/cli/nodes-cli.coverage.test.ts src/agents/tools/nodes-tool.test.ts src/agents/bash-tools.exec.approval-id.test.tspnpm vitest run src/infra/system-run-approval-context.test.tsnode scripts/run-node.mjs nodes statusnode scripts/run-node.mjs nodes run --node 'MacBook Pro (JetBook)' /bin/echo fallback-oknode scripts/run-node.mjs nodes run --node 'MacBook Pro (JetBook)' wacli doctor-> reached runtime, failed honestly with missing binary on nodenode scripts/run-node.mjs nodes run --node 'MacBook Pro (JetBook)' -- wacli chats list --limit 1 --json-> reached runtime, failed honestly with missing binary on nodeAI Assistance