fix(browser): retry Chrome MCP attach timeouts#800
Merged
artemgetmann merged 1 commit intoMay 27, 2026
Conversation
- Add a 60s existing-session attach budget shared by status and availability. - Retry Chrome MCP -32001/request-timeout attach failures until the outer caller deadline expires. - Cover direct availability, list_pages, and tool-call attach paths with focused regressions. - Risk: keeps retries limited to the Chrome MCP attach-timeout class to avoid masking real tool failures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
user-livecould fail around 19s withMCP error -32001: Request timed outeven when callers passed a 60s browser timeout.-32001/request-timeout failures until the outer caller deadline expires.Change Type (select all)
Scope (select all touched areas)
Linked Issue/PR
User-visible / Behavior Changes
Existing-session Chrome status/start follow-up checks now use a 60s attach budget, and Chrome MCP attach/readiness request timeouts are retried inside that budget before surfacing failure guidance.
Security Impact (required)
Yes, explain risk + mitigation: N/ARepro + Verification
Environment
user-liveexisting-session profile classSteps
MCP error -32001: Request timed outbefore the caller budget expires.list_pagesreturning the same retryable timeout once before succeeding.Expected
Actual
Evidence
Human Verification (required)
git diff --check.list_pagestimeout, availability preflight retry, caller timeout override propagation.Review Conversations
Compatibility / Migration
Failure Recovery (if this breaks)
src/browser/chrome-mcp.ts,src/browser/server-context.availability.ts,src/browser/client.ts,src/agents/tools/browser-tool.ts, related tests.Risks and Mitigations
-32001/ request-timeout / attach-timeout messages; tool-level errors still fail normally.