Skip to content

fix(browser): preserve user-live loopback attach guidance#811

Merged
artemgetmann merged 1 commit into
mainfrom
codex/user-live-loopback-guidance-20260528
May 28, 2026
Merged

fix(browser): preserve user-live loopback attach guidance#811
artemgetmann merged 1 commit into
mainfrom
codex/user-live-loopback-guidance-20260528

Conversation

@artemgetmann
Copy link
Copy Markdown
Owner

Review Fast Path

  • User path fixed: Telegram/main Jarvis browser.open(profile=user-live) through loopback browser-control no longer reports generic gateway restart/no-retry when Chrome remote-debugging approval is the real blocker.
  • Proof: pnpm exec vitest run src/browser/client-fetch.loopback-auth.test.ts src/agents/tools/browser-tool.test.ts -> 2 files / 59 tests passed; git diff --check passed.
  • Shared-state footgun removed: loopback HTTP and in-process dispatcher now return the same user-live Chrome approval/setup guidance for timeout/abort failures.
  • Still hurts: full Batik booking flow still needs shared-main/TUI proof after merge/restart; this PR does not change active-run lease behavior from fix(agent): renew active run timeout lease #805.

Why This Matters

  • PR fix(browser): self-heal user-live Chrome attach #803 fixed self-healing attach behavior, but the live booking run hit an absolute loopback browser-control path and surfaced: Restart the OpenClaw gateway ... Do NOT retry the browser tool.
  • That message is actively misleading for user-live: the user usually needs to approve Chrome remote debugging or enable it at chrome://inspect/#remote-debugging, not restart the gateway.

Scope Boundary

  • Changed only browser-control error guidance for profile=user-live timeout/abort failures.
  • Did not change browser auth, Chrome launch policy, debug-port selection, task leases, or durable timeout behavior.
  • Separate from fix(agent): renew active run timeout lease #805.

Verification

  • pnpm exec vitest run src/browser/client-fetch.loopback-auth.test.ts -> passed, 17 tests.
  • pnpm exec vitest run src/agents/tools/browser-tool.test.ts -> passed, 42 tests.
  • pnpm exec vitest run src/browser/client-fetch.loopback-auth.test.ts src/agents/tools/browser-tool.test.ts -> passed, 59 tests.
  • git diff --check -> passed.

AI Assistance

  • AI-assisted.
  • Testing degree: targeted.

- Map absolute loopback profile=user-live timeout and abort failures to Chrome remote-debugging approval guidance.
- Keep dispatcher and HTTP service timeout surfaces aligned without changing auth or Chrome launch policy.
- Add focused regressions for loopback abort and service timeout responses.
- Risk: low; only error-message mapping for user-live loopback browser-control failures.
@artemgetmann artemgetmann marked this pull request as ready for review May 28, 2026 13:06
@artemgetmann artemgetmann merged commit f4a25a7 into main May 28, 2026
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant