Skip to content

fix(telegram): remove visible tool trace text#835

Merged
artemgetmann merged 1 commit into
mainfrom
codex/telegram-tool-status-verbose-gate
May 31, 2026
Merged

fix(telegram): remove visible tool trace text#835
artemgetmann merged 1 commit into
mainfrom
codex/telegram-tool-status-verbose-gate

Conversation

@artemgetmann
Copy link
Copy Markdown
Owner

Review Fast Path

  • User path fixed: Telegram no longer renders tool/status trace text like 🔧 read, 🔧 cron, or text-only tool progress bubbles, even when /verbose is on.
  • Proof: pnpm exec vitest run extensions/telegram/src/bot-message-dispatch.test.ts src/auto-reply/reply/dispatch-from-config.test.ts src/auto-reply/reply/dispatch-acp-delivery.test.ts src/auto-reply/reply/acp-projector.test.ts -> 4 passed, 179 tests.
  • Shared-state footgun removed: removed the Telegram draft-progress path that turned tool lifecycle/status plumbing into product-visible chat text.
  • Still hurts: no live Telegram runtime proof in this lane by constraint; this is code/test proof only.

Why This Matters

  • Tool calls belong in logs, reactions, and internal status plumbing, not as Telegram product messages.
  • /verbose should not turn implementation traces into user-visible chat content.

Scope Boundary

  • Removed Telegram text-only tool progress rendering from the draft lane.
  • Changed shared Telegram dispatch so verbose no longer opts into visible tool summaries.
  • Preserved final answers, status reactions, media envelopes, explicit errors, and exec approval envelopes.
  • Did not restart or mutate any shared Telegram gateway/runtime.

Verification

  • pnpm exec oxfmt --write extensions/telegram/src/bot-message-dispatch.ts extensions/telegram/src/bot-message-dispatch.test.ts src/auto-reply/reply/dispatch-from-config.ts src/auto-reply/reply/dispatch-from-config.test.ts
  • pnpm exec vitest run extensions/telegram/src/bot-message-dispatch.test.ts src/auto-reply/reply/dispatch-from-config.test.ts src/auto-reply/reply/dispatch-acp-delivery.test.ts src/auto-reply/reply/acp-projector.test.ts
    • Result: 4 files passed, 179 tests passed.

AI Assistance

  • AI-assisted
  • Testing degree: targeted

- what: stop Telegram from rendering tool lifecycle/status text in chats, including verbose sessions, while preserving reactions plus media/error/approval envelopes.
- why: tool calls belong in logs/status plumbing, not product-visible Telegram messages.
- risk: Telegram no longer shows text-only tool progress bubbles; final answers and user-facing payload envelopes remain covered by targeted tests.
@artemgetmann artemgetmann marked this pull request as ready for review May 31, 2026 13:09
@artemgetmann artemgetmann merged commit aa86143 into main May 31, 2026
4 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant