Conversation
guddo
reviewed
Jun 28, 2017
| // And FBS can't tell us this. | ||
| 'reserved_count' => 0, | ||
| 'is_periodical' => FALSE, | ||
| 'reservation_count' => $item->reservations |
Contributor
There was a problem hiding this comment.
What is the difference between this and L81? reserved_count
Contributor
Author
There was a problem hiding this comment.
reservation_count is used here: https://github.com/artesis/fbs/blob/master/includes/fbs.availability.inc#L214
Contributor
There was a problem hiding this comment.
Well then I think you should remove reserved_count - makes no sense to keep both variables.
$ grep -r 'reserved_count' *
ding2/includes/fbs.availability.inc: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: * reserved_count: # int
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
ding2/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/includes/fbs.availability.inc: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: * reserved_count: # int
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
fbs/tests/AvailibilityProviderTest.php: 'reserved_count' => 0,
openruth/openruth.availability.inc: $h['reserved_count'] += $itemHolding->ordersCount;
openruth/openruth.availability.inc: 'reserved_count' => isset($holding->ordersCount) ? (int) $holding->ordersCount : 0,
openruth/openruth.availability.inc: $row['data']['Copies'] = array('data' => $h['reserved_count'], 'colspan' => 3);
$ grep -r 'reservation_count' *
ding_user_frontend/ding_user_frontend.module: 'variables' => array('loan_count' => NULL, 'reservation_count' => NULL, 'debt_count' => NULL),
ding_user_frontend/templates/ding_user_frontend_user_status.tpl.php: <span class="amount">(<?php print $reservation_count; ?>)</span>
fbs/includes/fbs.availability.inc: $reservation_count = (int) $res['reservation_count'];
fbs/includes/fbs.availability.inc: $result = _fbs_set_table_html($res['holdings'], $reservation_count);
fbs/includes/fbs.availability.inc: $reservation_count = 0;
fbs/includes/fbs.availability.inc: $reservation_count += (int) $records['reservation_count'];
fbs/includes/fbs.availability.inc: $result = _fbs_set_table_html($holdings, $reservation_count);
Contributor
There was a problem hiding this comment.
And the comment on L80 is now not valid anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.