ci(copilot-review): migrate from gh-dagentic to release/@v1#5
Merged
Conversation
The previous reusable workflow at arthur-debert/gh-dagentic/.github/workflows/copilot-review.yml@main authenticates with GITHUB_TOKEN, which is github-actions[bot] (Integration actor). Integration actors silently no-op Copilot review-attach: 'gh pr edit --add-reviewer @copilot' returns the PR URL with no error but adds nothing. release/@v1 requires the caller to pass a user PAT via secrets.gh_token. RELEASE_TOKEN already exists on this repo (or will once propagated), so wiring it through fixes the silent failure. Caught by bin/audit-smoke-test on arthur-debert/dodot — this commit sweeps the rest.
There was a problem hiding this comment.
Pull request overview
This PR migrates the repository’s Copilot review-request GitHub Actions workflow to a newer reusable workflow that supports authenticating with a user PAT (instead of GITHUB_TOKEN) so that the Copilot reviewer is actually attached to PRs.
Changes:
- Switch reusable workflow reference from
arthur-debert/gh-dagentic/...@maintoarthur-debert/release/...@v1. - Pass a caller-provided PAT (
secrets.RELEASE_TOKEN) into the reusable workflow viasecrets.gh_token.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+17
| uses: arthur-debert/release/.github/workflows/copilot-review.yml@v1 | ||
| with: | ||
| pr_number: ${{ github.event.pull_request.number }} | ||
| secrets: | ||
| gh_token: ${{ secrets.RELEASE_TOKEN }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
.github/workflows/copilot-review.ymlfromarthur-debert/gh-dagentic/.github/workflows/copilot-review.yml@maintoarthur-debert/release/.github/workflows/copilot-review.yml@v1.Why
The gh-dagentic reusable workflow authenticates with
GITHUB_TOKEN.GITHUB_TOKENauthenticates asgithub-actions[bot](Integration actor), and Integration actors silently no-op the Copilot review-attach. Sogh pr edit --add-reviewer @copilotreturned the PR URL with no error, but added nothing.release/@v1 fixes this by requiring the caller to pass a user PAT (
RELEASE_TOKEN) viasecrets.gh_token.Caught by
bin/audit-smoke-testagainst arthur-debert/dodot, which opened a real PR and verified the Copilot reviewer did not actually get attached even though the workflow ran successfully. See arthur-debert/release#2.Auto-generated
This PR was opened by
bin/migrate-copilot-review. Same change rolling out to all other consumers.