-
-
Notifications
You must be signed in to change notification settings - Fork 55
added react hook usage to documentation for further clarity #145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/arthurdenner/react-semantic-ui-datepickers/cblwckclim |
|
@artawood, your PR is on point, thank you! I was thinking, could you fix the typo in |
|
@arthurdenner, typo is fixed, and I updated the two examples with hook usage. I hope the second example is more helpful as it add clarity the expected value retrieved for the range is an array. |
arthurdenner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@artawood, yes, the second example is nice.
I noticed one minor thing that was my mistake when giving you the example.
Can you accept the suggestion, please?
After this, I'll merge it. Thanks!
|
Thank you for your contribution, @artawood! 🎉 |
|
@all-contributors please add @artawood for doc. |
|
I've put up a pull request to add @artawood! 🎉 |
|
@arthurdenner Thanks! Happy to contribute! 👍 |
|
🎉 This PR is included in version 2.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This is to add to the documentation an example of react hook for usage and add clarity to how the date is retrieved with params
(event, date)and displayed from propertyvalueviadata.valueCloses #144.