Fix the broken docker scripts #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am far from a docker expert, but the original scripts were complaining that jekyll/stable didn't exist. In addition, CTRL+C was not killing the livetest docker container. With these changes both things seem to work for me. I recommend manually testing these yourself before merging.
ghost
changed the title
Author
|
It might be worth noting that I haven't had any problems with the test.sh script. |
Collaborator
|
livetest.sh had the baseurl='' because otherwise jekyll would cook up incorrect localhost headers. I'll pull this down and test it. |
pnathan
added a commit
that referenced
this pull request
Sep 11, 2015
Fix the broken docker scripts. Depending on third-party artifacts always bites you. Always.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am far from a docker expert, but the original scripts were complaining
that jekyll/stable didn't exist. In addition, CTRL+C was not killing the
livetest docker container.
With these changes both things seem to work for me. I recommend manually
testing these yourself before merging.