Fix pie chart auto-play stopping on no-transfer rounds#618
Closed
skaphan wants to merge 10 commits intoartoonie:mainfrom
Closed
Fix pie chart auto-play stopping on no-transfer rounds#618skaphan wants to merge 10 commits intoartoonie:mainfrom
skaphan wants to merge 10 commits intoartoonie:mainfrom
Conversation
Add resumeFrom() to round player so the pie chart can advance the dropdown during auto-play without stopping playback. When the pie chart skips a round with no transfers, updateRound() now calls resumeFrom() instead of setStep() to keep the animation going. Co-Authored-By: Claude Opus 4.6
Revert round-player.js changes. The simpler approach is to skip the setStep() call entirely during auto-play so it does not stop playback. The round player timer catches up on its next tick. Co-Authored-By: Claude Opus 4.6
artoonie
approved these changes
Apr 8, 2026
Merged
The no-transfer round skipping has been reverted from the pie chart component, so the workaround in updateRound is no longer needed. Co-Authored-By: Claude Opus 4.6
Skip no-transfer rounds during pie chart animation by requesting the controller to advance immediately. Remove firstStepHoldTimeMs workaround since the first step now fires immediately. Co-Authored-By: Claude Opus 4.6
The timer delay is for between steps, not before the first one. Removes the need for the firstStepHoldTimeMs workaround. Co-Authored-By: Claude Opus 4.6
Owner
|
Does this deprecate firstStepTimeMs? If so, we should remove it. |
Contributor
Author
|
I didn't know if it was something you wanted to have for other uses. You can get rid of it as far as I'm concerned.
… On Apr 9, 2026, at 11:15 AM, Armin Samii ***@***.***> wrote:
artoonie
left a comment
(artoonie/rcvis#618)
<#618 (comment)>
Does this deprecate firstStepTimeMs? If so, we should remove it.
—
Reply to this email directly, view it on GitHub <#618 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABCNY6GSVJNWZLNEWTIGT34U7SCRAVCNFSM6AAAAACXQK2X42VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJWGQ2TEMJYGI>.
You are receiving this because you authored the thread.
|
Owner
|
Ah, I see, it is still in use. Great! |
Merged
Owner
|
Merged in #622 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pie chart component now skips rounds with no transfers (e.g. a candidate elected with no surplus to redistribute). When this happens during auto-play, the component calls
requestRoundChangeto advance to the next round, which triggerssetStep()on the round player — andsetStep()stops playback.This is a workaround: during auto-play,
updateRound()skips thesetStep()call so the round player timer keeps running. The dropdown will be briefly out of sync but catches up on the next tick.Ideally, the round player would respond to the round change by immediately advancing to the next round and continuing the animation, rather than requiring the caller to avoid
setStep()during playback.Test plan
🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6