feat: empty state tracking on artist page and auction result tracking#686
Merged
Conversation
this event stopped firing in 2023, but appeared to be for auction results on the /artist/name/auction-results page
updates clickedArticleGroup and clickedAuctionResultItem examples to match the new possible type: "emptyState" and provides examples for auction results
Collaborator
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of this PR is: feat
This PR resolves DIAM-363
Description
Empty state behavior for the Artist page should use the new
type=emptyStatesubfield for these two currently untracked pathways.Clicking an auction Result normally on the Artist or Auction Result page should fire with the example schema.
expandedcan remainnullalways; this appears to be from a legacy version of the page (the lastclickedAuctionResultItemevent was in 2023. I made it optional so we can ignore this subfieldcontext_page_owner_slugcan populate on Artist pages, but remainNULLon Auction Result pages.Empty state
PR Checklist (tick all before merging)
index.tsclickandtap(platform is inferred by the DB storing events)