Skip to content

chore: use new auth method field rather than expanding triggers#695

Merged
brainbicycle merged 1 commit into
mainfrom
brian/one-tap-again
May 21, 2026
Merged

chore: use new auth method field rather than expanding triggers#695
brainbicycle merged 1 commit into
mainfrom
brian/one-tap-again

Conversation

@brainbicycle
Copy link
Copy Markdown
Contributor

The type of this PR is: chore

This PR resolves [CO-]

Description

Switch trigger out for a new method field as it does not really fit conceptually with other triggers.
Analytics pr that is still not merged is only thing passing the modified trigger so should be okay to remove.

PR Checklist (tick all before merging)

  • If I've added a new file to the tree I've exported it from the common index.ts
  • I've added comments with examples for any new interfaces and ensured that they're in the docs
  • No platform-specific terminology has been used outside of click and tap (platform is inferred by the DB storing events)

Copy link
Copy Markdown
Contributor

@xander-pero xander-pero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@brainbicycle brainbicycle merged commit bad34d5 into main May 21, 2026
9 checks passed
@brainbicycle brainbicycle deleted the brian/one-tap-again branch May 21, 2026 15:26
@artsyit
Copy link
Copy Markdown
Collaborator

artsyit commented May 21, 2026

🚀 PR was released in v4.356.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Version: Minor A deploy for new features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants