fix: invalidate deeplink timeout in new nav #trivial#11287
Merged
brainbicycle merged 1 commit intomainfrom Dec 16, 2024
Merged
Conversation
Contributor
MounirDhahri
approved these changes
Dec 16, 2024
Comment on lines
+85
to
+87
| if (currentRoute && Platform.OS === "ios") { | ||
| LegacyNativeModules.ARTDeeplinkTimeoutModule.invalidateDeeplinkTimeout() | ||
| } |
Member
There was a problem hiding this comment.
can this be also invalidated within the handle deep hook?
Contributor
Author
There was a problem hiding this comment.
It could but I think it would make it less valuable, the idea is to see if the deeplink successfully resulted in navigation, so if we put it there something could still go wrong in the navigate function or more likely the thread is busy and the navigation never gets called
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Invalidate the timeout for our little failed deeplink tracking that didn't get carried over to new nav.
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.