Skip to content

Comments

feat(ONYX-1604): track progressive onboarding tooltips#11657

Merged
artsy-peril[bot] merged 8 commits intomainfrom
dariakoko/track-pregressive-onboarding-tooltips
Mar 17, 2025
Merged

feat(ONYX-1604): track progressive onboarding tooltips#11657
artsy-peril[bot] merged 8 commits intomainfrom
dariakoko/track-pregressive-onboarding-tooltips

Conversation

@dariakoko
Copy link
Contributor

@dariakoko dariakoko commented Mar 12, 2025

This PR resolves ONYX-1604

Description

Track progressive onboarding tooltips
Track then visible

Partially relevant slack thread with Xander: https://artsy.slack.com/archives/C05EQL4R5N0/p1741116191231399

tracking event:

    action: ActionType.tooltipViewed;
    context_owner_type?: OwnerType;
    context_module: ContextModule
    type: string;

> NOTE: context_owner_type is optional and will be missing for the 'save-artwork' onboarding tooltip only. Adding it will require some prop drilling, data said it's fine, but I'm open to other opinions.

Some examples of the tracking event:

Alert create reminder Alert create Long Press
Simulator Screenshot - iPhone 16 Pro Max - 2025-03-12 at 11 41 27 Simulator Screenshot - iPhone 16 Pro Max - 2025-03-12 at 11 40 50 Simulator Screenshot - iPhone 16 Pro Max - 2025-03-12 at 11 38 56

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • track progressive onboarding tooltips

Need help with something? Have a look at our docs, or get in touch with us.

@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Mar 12, 2025

This PR contains the following changes:

  • Dev changes (track progressive onboarding tooltips - dariakoko)

Generated by 🚫 dangerJS against deb063d

@dariakoko dariakoko requested a review from olerichter00 March 15, 2025 10:49
olerichter00
olerichter00 previously approved these changes Mar 17, 2025
@artsy-peril artsy-peril bot merged commit dd9f22a into main Mar 17, 2025
7 checks passed
@artsy-peril artsy-peril bot deleted the dariakoko/track-pregressive-onboarding-tooltips branch March 17, 2025 09:59
MounirDhahri pushed a commit that referenced this pull request Mar 17, 2025
* feat: track pregressive onboarding tooltips

* chore: address review comments

* chore: address review comments

* chore: update cohesion version

* chore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants