Skip to content

Comments

refactor(BidButton): convert class component to functional component#11672

Merged
nickskalkin merged 1 commit intomainfrom
nickskalkin/refactor-bid-button
Mar 18, 2025
Merged

refactor(BidButton): convert class component to functional component#11672
nickskalkin merged 1 commit intomainfrom
nickskalkin/refactor-bid-button

Conversation

@nickskalkin
Copy link
Contributor

Description

Refactored BidButton from a class component to a functional component using modern React practices:

  • Replace @track decorator with useTracking hook
  • Convert class methods to functional component functions
  • Use proper tracking patterns
  • Simplified component structure

All tests passing, no functionality changes.

🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com
Co-Authored-By: George g.kartalis7@gmail.com

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

Refactored BidButton from a class component to a functional component using modern React practices:
- Replace @track decorator with useTracking hook
- Convert class methods to functional component functions
- Use proper tracking patterns
- Simplified component structure

All tests passing, no functionality changes.

🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: George <g.kartalis7@gmail.com>
Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niiice ❤️

@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Dev changes (refactor bid button component - @nickskalkin - nickskalkin)

Generated by 🚫 dangerJS against 0c61f74

Copy link
Contributor

@brainbicycle brainbicycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impressive, that all looks like pretty reasonable code! and less type errors!

Copy link
Contributor

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yess

Copy link
Member

@anandaroop anandaroop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😎

@nickskalkin nickskalkin merged commit ade6be1 into main Mar 18, 2025
7 checks passed
@nickskalkin nickskalkin deleted the nickskalkin/refactor-bid-button branch March 18, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants