feat: add Favorites tab to bottom navigation#11686
Conversation
- Added new feature flag AREnableFavoritesTab (default: false) - Added heart icon for Favorites tab - Added conditional rendering based on feature flag - Placed tab between Inbox and Profile tabs - Added analytics tracking 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Mounir Dhahri <soussouheros@gmail.com>
Co-authored-by: Nikita Skalkin <nikskalkin@gmail.com>
MounirDhahri
force-pushed
the
feature/favorites-tab
branch
from
e16b6b3 to
94d66a4
Compare
anandaroop
left a comment
anandaroop
left a comment
There was a problem hiding this comment.
Nice 😎
The 2nd commit mentions following up on Claude. What kind of follow-up was necessary? Did it involve e.g a substantive change to the SVG code?
| }, | ||
| favorites: { | ||
| route: "/favorites", | ||
| analyticsDescription: OwnerType.favorites, |
There was a problem hiding this comment.
question (non-blocking): Noticing the different owner type here vs above, I assume it's intentional?
There was a problem hiding this comment.
no that was a mistake - I will address it
dariakoko
left a comment
dariakoko
left a comment
There was a problem hiding this comment.
Wow that's impressive. How much of it was generated by Claude?
| return ( | ||
| <ProvideScreenTracking | ||
| info={{ | ||
| context_screen: Schema.PageNames.SavesAndFollows, |
There was a problem hiding this comment.
Question: Is it intentional that this does not come from Cohesion?
There was a problem hiding this comment.
This file probably precedes all of us and is maybe from a time before cohesion existed 😄. We didn't make changes to it because it's going to get removed once we roll out.
|
The first commit was all Claude.
That being said, it quickly adjusted to our prompts and it even generated a heart icon that was still within the bottom tab (didn't require any pixel adjustments). |
| }, | ||
| favorites: { | ||
| active: ( | ||
| <Path |
There was a problem hiding this comment.
This icon should be on Icons repo
There was a problem hiding this comment.
Definitely - we have a separate ticket to address the Icons on the navbar
MounirDhahri
dismissed stale reviews from olerichter00, dariakoko, and anandaroop
via
c9b606f
7 participants
🤖 Generated with Claude Code
This PR resolves ONYX-1599
Description
This PR adds the boilerplate code requires for the new favorites hub.
Screen.Recording.2025-03-14.at.12.39.27.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.