Skip to content

fix: using default values for hitSlop on Touchable components #11704

Merged
JanaeHijaz merged 1 commit intomainfrom
janaehijaz/default-hit-slop
Mar 18, 2025
Merged

fix: using default values for hitSlop on Touchable components #11704
JanaeHijaz merged 1 commit intomainfrom
janaehijaz/default-hit-slop

Conversation

@JanaeHijaz
Copy link
Contributor

@JanaeHijaz JanaeHijaz commented Mar 17, 2025

Description

Updating this component to take in the default values from palette-mobile.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • Updating this component to take in the default values from palette-mobile.

Need help with something? Have a look at our docs, or get in touch with us.

@JanaeHijaz JanaeHijaz self-assigned this Mar 17, 2025
@JanaeHijaz JanaeHijaz requested a review from damassi March 17, 2025 23:28
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Mar 17, 2025

This PR contains the following changes:

  • Dev changes (Updating this component to take in the default values from palette-mobile. - JanaeHijaz)

Generated by 🚫 dangerJS against 489a347

Copy link
Contributor

@damassi damassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up! 🙏

@JanaeHijaz JanaeHijaz force-pushed the janaehijaz/default-hit-slop branch from d2b0b80 to 489a347 Compare March 18, 2025 16:27
@JanaeHijaz JanaeHijaz merged commit 581eade into main Mar 18, 2025
7 checks passed
@JanaeHijaz JanaeHijaz deleted the janaehijaz/default-hit-slop branch March 18, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments