Skip to content

Comments

fix: make only artwork image tappable#11710

Merged
MounirDhahri merged 1 commit intomainfrom
fix/make-only-artwork-image-tappable
Mar 18, 2025
Merged

fix: make only artwork image tappable#11710
MounirDhahri merged 1 commit intomainfrom
fix/make-only-artwork-image-tappable

Conversation

@MounirDhahri
Copy link
Member

Description

This PR makes sure that only the header part of the artwork is tappable instead of just the image.

Screen.Recording.2025-03-18.at.14.11.03.mov

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

  • fix(infinite-discovery): make only artwork image tappable - mounir

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri requested a review from iskounen March 18, 2025 13:17
@MounirDhahri MounirDhahri self-assigned this Mar 18, 2025
@ArtsyOpenSource
Copy link
Contributor

This PR contains the following changes:

  • Cross-platform user-facing changes (fix(infinite-discovery): make only artwork image tappable - mounir - MounirDhahri)

Generated by 🚫 dangerJS against fa2720c

Copy link
Contributor

@iskounen iskounen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense 👍

@MounirDhahri MounirDhahri merged commit 363bd4d into main Mar 18, 2025
4 of 5 checks passed
@MounirDhahri MounirDhahri deleted the fix/make-only-artwork-image-tappable branch March 18, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants