Skip to content

Comments

feat: Prefetch home view navigation pill links#11711

Merged
olerichter00 merged 1 commit intomainfrom
olerichter00/prefetch-home-view-navigation-pill-links
Mar 18, 2025
Merged

feat: Prefetch home view navigation pill links#11711
olerichter00 merged 1 commit intomainfrom
olerichter00/prefetch-home-view-navigation-pill-links

Conversation

@olerichter00
Copy link
Contributor

@olerichter00 olerichter00 commented Mar 18, 2025

Description

Prefetch home view navigation pill links.

Screenshots / Videos

After:

Simulator.Screen.Recording.-.iPhone.16.-.2025-03-18.at.15.08.29.mp4

Before:

Simulator.Screen.Recording.-.iPhone.16.-.2025-03-18.at.15.09.30.mp4

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

Need help with something? Have a look at our docs, or get in touch with us.

@olerichter00 olerichter00 self-assigned this Mar 18, 2025
@ArtsyOpenSource
Copy link
Contributor

Warnings
⚠️

An error occurred while validating your changelog, please make sure you provided a valid changelog.

Generated by 🚫 dangerJS against c8dafc2

Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this update. Do you mind if you attach a video to show the pill will look like when it's pressed now. Just to make sure that its styles do not break because the onPress is being captured by its parent

@olerichter00
Copy link
Contributor Author

Do you mind if you attach a video to show the pill will look like when it's pressed now. Just to make sure that its styles do not break because the onPress is being captured by its parent

Good idea 👍 I've added videos with the pill interaction before and after the change.

Copy link
Member

@MounirDhahri MounirDhahri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks a lot @olerichter00

@olerichter00 olerichter00 merged commit 6db2f81 into main Mar 18, 2025
7 checks passed
@olerichter00 olerichter00 deleted the olerichter00/prefetch-home-view-navigation-pill-links branch March 18, 2025 14:24
@damassi
Copy link
Contributor

damassi commented Mar 18, 2025

So fast

Flex,
FlexProps,
FollowArtistIcon,
AuctionIcon as GavelIcon,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to reassign variable names like this 🤔 It will just make refactoring harder later, due to 1:2 variable assignment (an auction icon is no longer just an auction icon; it is now also a gavel icon too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants