feat: Prefetch home view navigation pill links#11711
Conversation
MounirDhahri
left a comment
There was a problem hiding this comment.
thanks for this update. Do you mind if you attach a video to show the pill will look like when it's pressed now. Just to make sure that its styles do not break because the onPress is being captured by its parent
Good idea 👍 I've added videos with the pill interaction before and after the change. |
MounirDhahri
left a comment
There was a problem hiding this comment.
LGTM - thanks a lot @olerichter00
|
So fast |
| Flex, | ||
| FlexProps, | ||
| FollowArtistIcon, | ||
| AuctionIcon as GavelIcon, |
There was a problem hiding this comment.
Do we need to reassign variable names like this 🤔 It will just make refactoring harder later, due to 1:2 variable assignment (an auction icon is no longer just an auction icon; it is now also a gavel icon too)
Description
Prefetch home view navigation pill links.
Screenshots / Videos
After:
Simulator.Screen.Recording.-.iPhone.16.-.2025-03-18.at.15.08.29.mp4
Before:
Simulator.Screen.Recording.-.iPhone.16.-.2025-03-18.at.15.09.30.mp4
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.