fix: fix progressive onboarding tooltips#11715
Merged
artsy-peril[bot] merged 6 commits intomainfrom Mar 19, 2025
Merged
Conversation
Co-authored-by: Mounir Dhahri <soussouheros@gmail.com>
Co-authored-by: Mounir Dhahri <soussouheros@gmail.com>
Contributor
MounirDhahri
approved these changes
Mar 19, 2025
Member
MounirDhahri
left a comment
MounirDhahri
left a comment
There was a problem hiding this comment.
Thank you! this should do it until we revisit our alerts implementation
dariakoko
commented
Mar 19, 2025
Comment on lines
+354
to
+357
| jest.mock("app/utils/hooks/useDebouncedValue", () => ({ | ||
| useDebouncedValue: ({ value }: any) => ({ debouncedValue: value }), | ||
| })) | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Thanks! I was just mocking debounce for every test separately
Does your implementation have any risks?
MounirDhahri
added a commit
that referenced
this pull request
Mar 19, 2025
* fix: popovers blocking the screen Co-authored-by: Mounir Dhahri <soussouheros@gmail.com> * fix: dismiss alert-finish at a right place Co-authored-by: Mounir Dhahri <soussouheros@gmail.com> * feat: hide tooltip on saved behind a feature flag * fix: broken tests * chore: increase duration between taps on android * fix: ts issue --------- Co-authored-by: Mounir Dhahri <soussouheros@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves []
Description
Fix progressive onboarding tooltips make app freeze
Co-authored-by: @MounirDhahri
POPOVERS.webm
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.