feat: add follows to favorites tab#11728
Conversation
| }} | ||
| keyExtractor={(item, index) => item.artist?.id || index.toString()} | ||
| contentContainerStyle={{ paddingVertical: space(1) }} | ||
| onEndReachedThreshold={0.2} |
There was a problem hiding this comment.
question: what's the reason to not use the default here?
There was a problem hiding this comment.
I kept this to be the same as use it for the current FavortesArtists - there was no comment about it so I assumed it's probably no accidental
There was a problem hiding this comment.
Alright, 0.2 seems to be our default. I've created a ticket to revisit and adjust the threshold for the artwork grid where pages are loaded quite late. I think we can improve the "scrolling through the artwork grid" experience by loading pages earlier.
| contentContainerStyle={{ paddingVertical: space(1) }} | ||
| onEndReachedThreshold={0.2} | ||
| refreshControl={RefreshControl} | ||
| style={{ paddingHorizontal: 0 }} |
There was a problem hiding this comment.
unfortunately <Tabs.FlashList /> injects its own paddingHorizontal from palette and this is to override it.
| key={value} | ||
| onPress={() => { | ||
| setfollowOption(value) | ||
| // Dismiss after a short delay to make sure the user can verify their choice |
There was a problem hiding this comment.
question: This code automatically closes the bottom sheet when the user clicks on the radio button, right?
There was a problem hiding this comment.
I’ve experimented with it, and I think we could remove or at least reduce the timeout to make it snappier.
There was a problem hiding this comment.
I will decrease it, and if it doesn't look good I can remove it
| onEndReached={() => { | ||
| loadNext(PAGE_SIZE) | ||
| }} | ||
| keyExtractor={(item, index) => item.id || index.toString()} |
There was a problem hiding this comment.
minor: can't we just use item.id here? I would expect it to always be present
There was a problem hiding this comment.
id can be null from MP - it's never null though in practice
4 participants
This PR resolves ONYX-1602
Description
This PR adds the follows tab to the favorites bottom tab.
Screen.Recording.2025-03-19.at.16.01.31.mov
Screen.Recording.2025-03-19.at.16.00.18.mov
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.