chore: add auth screen tracking #trivial #13069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brainbicycle
commented
Dec 5, 2025
|
|
||
| useEffect(() => { | ||
| tracking.authImpression() | ||
| tracking.authModalScreenView() |
Contributor
Author
There was a problem hiding this comment.
wrapping with cohesion provider oddly seemed to affect performance, since we already have this just added it here.
araujobarret
previously approved these changes
Dec 5, 2025
gkartalis
previously approved these changes
Dec 5, 2025
dariakoko
previously approved these changes
Dec 5, 2025
MounirDhahri
reviewed
Dec 5, 2025
Member
MounirDhahri
left a comment
MounirDhahri
left a comment
There was a problem hiding this comment.
LGTM, apart from a few minor comments
| </Flex> | ||
| </MotiView> | ||
| </Box> | ||
| // </KeyboardAvoidingView> |
Contributor
Author
There was a problem hiding this comment.
just a commented out component i removed
src/app/Scenes/Onboarding/Screens/Auth/hooks/useOnboardingAuthTracking.tsx
Outdated
Show resolved
Hide resolved
brainbicycle
dismissed stale reviews from dariakoko, gkartalis, and araujobarret
via
a735a8f
brainbicycle
force-pushed
the
brian/auth-screen-tracking
branch
from
e9d99a5 to
55c14e0
Compare
brainbicycle
added
the
Squash On Green
Contributor
araujobarret
pushed a commit
that referenced
this pull request
Dec 10, 2025
* add authModal screen tracking - untested * useEffect approach to avoid render issues * use string from cohesion * update cohesion to fix types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves DIAM-213
Description
Adds an auth screen event to fix issues with unreliable auth analytics.
Should merge this first and use the value from cohesion:
artsy/cohesion#666 😈
PR Checklist
To the reviewers 👀
Changelog updates
Changelog updates
Cross-platform user-facing changes
iOS user-facing changes
Android user-facing changes
Dev changes
Need help with something? Have a look at our docs, or get in touch with us.