Skip to content

chore: update TOCropViewController to resolve hack #trivial#3956

Merged
pvinis merged 1 commit intomasterfrom
tocropviewcontroller-update
Sep 30, 2020
Merged

chore: update TOCropViewController to resolve hack #trivial#3956
pvinis merged 1 commit intomasterfrom
tocropviewcontroller-update

Conversation

@ashfurrow
Copy link
Copy Markdown
Contributor

@ashfurrow ashfurrow commented Sep 30, 2020 •
edited by atlassian Bot
Loading

The type of this PR is: upkeep

Description

This resolves a hack introduced in #3938.

PR Checklist (tick all before merging)

  • I have included screenshots or videos to illustrate my changes, or I have not changed anything that impacts the UI.
  • I have added tests for my changes, or my changes don't require testing, or I have included a link to a separate Jira ticket covering the tests.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added an app state migration, or my changes do not require one. (What are migrations?)
  • I have added a CHANGELOG.yml entry or my changes do not require one.

@ashfurrow ashfurrow mentioned this pull request Sep 30, 2020
Closed
@pvinis
Copy link
Copy Markdown
Contributor

pvinis commented Sep 30, 2020

#squashongreen 😑

@pvinis pvinis merged commit 325f9a8 into master Sep 30, 2020
@pvinis pvinis deleted the tocropviewcontroller-update branch September 30, 2020 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@pvinis pvinis pvinis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pvinis pvinis

Labels

Jira Synced

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ashfurrow @pvinis