Skip to content

feat: add Test tab to sidebar with Coming Soon screen#20

Closed
arul28 wants to merge 1 commit intomainfrom
ade/integration-test-tab-coming-soon-03997efb
Closed

feat: add Test tab to sidebar with Coming Soon screen#20
arul28 wants to merge 1 commit intomainfrom
ade/integration-test-tab-coming-soon-03997efb

Conversation

@arul28
Copy link
Copy Markdown
Owner

@arul28 arul28 commented Mar 6, 2026

Summary

  • Added a new Test tab to the desktop app sidebar (/test route)
  • Created a TestPage component that displays a Coming Soon screen
  • Wired up the Flask icon, nav item, route, and AppShell tint map entry

Changes

  • TabNav.tsx — Flask icon import + /test nav item in mainItems
  • App.tsx — lazy TestPage import + /test React Router route
  • AppShell.tsx"/test": "tab-tint-missions" tint map entry
  • apps/desktop/src/renderer/components/test/TestPage.tsx — new page with "Coming Soon" message

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 6, 2026

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Free

Run ID: 5d7b9158-fc46-4870-87aa-3d67cddc844d

📥 Commits

Reviewing files that changed from the base of the PR and between c0dbcb2 and 5044e5e.

📒 Files selected for processing (4)
  • apps/desktop/src/renderer/components/app/App.tsx
  • apps/desktop/src/renderer/components/app/AppShell.tsx
  • apps/desktop/src/renderer/components/app/TabNav.tsx
  • apps/desktop/src/renderer/components/test/TestPage.tsx

📝 Walkthrough

Walkthrough

The changes introduce a new test page feature by adding a lazy-loaded TestPage component, registering a /test route with tint styling, and adding a corresponding navigation menu item with a Flask icon.

Changes

Cohort / File(s) Summary
Route Registration & Navigation
apps/desktop/src/renderer/components/app/App.tsx, apps/desktop/src/renderer/components/app/AppShell.tsx, apps/desktop/src/renderer/components/app/TabNav.tsx
Adds new /test route with lazy-loaded TestPage component, tint mapping aligned with /missions styling, and Flask-icon navigation item to access the test page.
Test Page Component
apps/desktop/src/renderer/components/test/TestPage.tsx
New React component that renders a centered "Coming Soon" placeholder with static subtitle text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

Comment @coderabbitai help to get the list of available commands and usage tips.

@arul28 arul28 closed this Mar 9, 2026
@arul28 arul28 deleted the ade/integration-test-tab-coming-soon-03997efb branch March 9, 2026 23:24
arul28 added a commit that referenced this pull request Apr 14, 2026
Part A — fix 22 branch-introduced test failures:
- TerminalView: add DEFAULT_TERMINAL_FONT_FAMILY to appStore mock + fontFamily to terminalPreferences (8 tests)
- AgentChatMessageList: update bubble max-w assertion to match widened responsive class (1 test)
- appStore: include fontFamily in terminalPreferences expectations; switch persistence assertions to unified store (2 tests)
- CtoSettingsPanel: navigate to correct sub-tab in 4 tests, drop 3 tests for removed UI (Configured/Needs work badges, CTO runtime header), update tag/button assertions (11 tests)

Part B — apply 5 low-risk optimizations from docs/OPTIMIZATION_OPPORTUNITIES.md:
- #2 Pause renderer watchdog when tab hidden (main.tsx): start/stop the 1s event-loop-stall interval based on document.visibilityState.
- #10 Combine warmup timers (appStore.ts): merge warmLaneStatusTimer + warmProviderModeTimer into a single warmupTimer firing both refreshes after max(1200, 1800) ms.
- #13 Hoist inline config objects (IntegrationTab.tsx): OutcomeDot config moved to module-scope OUTCOME_DOT_CONFIG. AppShell was already module-scoped.
- #19 Atomic UserPreferences store (appStore.ts): theme / terminalPreferences / smartTooltipsEnabled now persist as one ade.userPreferences.v1 JSON; legacy per-key reads kept as one-time migration.
- #20 Compact JSON for machine files: preload.ts audited — no pretty-printed JSON.stringify remained, no-op for this pass.

Doc: append "## Applied" section to docs/OPTIMIZATION_OPPORTUNITIES.md describing the five changes.

Verified: typecheck clean; all 8 vitest shards pass; npm run build succeeded.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
arul28 added a commit that referenced this pull request Apr 14, 2026
* Improve Tasks and Subagents panel typography and sizing

Bump text sizes across BottomDrawerSection, ChatTasksPanel, ChatSubagentsPanel,
and ChatSubagentStrip to be more readable (e.g. 9px→11px, 10px→12px, 11px→13px).
Switch labels, descriptions, and buttons from font-mono to the system sans font,
keeping monospace only where it belongs (timestamps, task IDs, tool names, status
badges). Slightly increase icon sizes and padding for better visual weight.

* Widen assistant message cards on large screens

Change max-width from 78ch to min(96ch, 75%) so messages use more
horizontal space on wide displays while still staying readable and
not stretching edge-to-edge.

* Fix drifted tests and apply safe renderer optimizations

Part A — fix 22 branch-introduced test failures:
- TerminalView: add DEFAULT_TERMINAL_FONT_FAMILY to appStore mock + fontFamily to terminalPreferences (8 tests)
- AgentChatMessageList: update bubble max-w assertion to match widened responsive class (1 test)
- appStore: include fontFamily in terminalPreferences expectations; switch persistence assertions to unified store (2 tests)
- CtoSettingsPanel: navigate to correct sub-tab in 4 tests, drop 3 tests for removed UI (Configured/Needs work badges, CTO runtime header), update tag/button assertions (11 tests)

Part B — apply 5 low-risk optimizations from docs/OPTIMIZATION_OPPORTUNITIES.md:
- #2 Pause renderer watchdog when tab hidden (main.tsx): start/stop the 1s event-loop-stall interval based on document.visibilityState.
- #10 Combine warmup timers (appStore.ts): merge warmLaneStatusTimer + warmProviderModeTimer into a single warmupTimer firing both refreshes after max(1200, 1800) ms.
- #13 Hoist inline config objects (IntegrationTab.tsx): OutcomeDot config moved to module-scope OUTCOME_DOT_CONFIG. AppShell was already module-scoped.
- #19 Atomic UserPreferences store (appStore.ts): theme / terminalPreferences / smartTooltipsEnabled now persist as one ade.userPreferences.v1 JSON; legacy per-key reads kept as one-time migration.
- #20 Compact JSON for machine files: preload.ts audited — no pretty-printed JSON.stringify remained, no-op for this pass.

Doc: append "## Applied" section to docs/OPTIMIZATION_OPPORTUNITIES.md describing the five changes.

Verified: typecheck clean; all 8 vitest shards pass; npm run build succeeded.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant