Skip to content

fix(tests): dedupe imports + permission-mode types from #202 consolidation #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arul28 merged 1 commit into from
Apr 26, 2026
Merged

fix(tests): dedupe imports + permission-mode types from #202 consolidation #204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions apps/desktop/src/main/services/cto/ctoWorkerLifecycle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import YAML from "yaml";
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import type { AgentIdentity } from "../../../shared/types";
import type { AgentIdentity, WorkerAgentRunStatus, WorkerAgentWakeupReason } from "../../../shared/types";
import { EventEmitter } from "node:events";
import { afterEach, describe, expect, it, vi } from "vitest";
Expand All @@ -13,10 +12,6 @@ import { createWorkerBudgetService } from "./workerBudgetService";
import { createWorkerHeartbeatService } from "./workerHeartbeatService";
import { createWorkerRevisionService } from "./workerRevisionService";
import { createWorkerTaskSessionService } from "./workerTaskSessionService";
import { describe, expect, it } from "vitest";
import { describe, expect, it, vi } from "vitest";
import { describe, expect, it, vi, afterEach } from "vitest";
import { openKvDb } from "../state/kvDb";
import { openKvDb, type AdeDb } from "../state/kvDb";

describe("workerHeartbeatService (file group)", () => {
Expand Down
4 changes: 1 addition & 3 deletions apps/desktop/src/main/services/cto/linearIntake.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,16 @@ import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import type {
LinearWorkflowConfig,
LinearWorkflowDefinition,
LinearWorkflowRun,
NormalizedLinearIssue,
} from "../../../shared/types";
import type { LinearWorkflowConfig, NormalizedLinearIssue } from "../../../shared/types";
import { afterEach, describe, expect, it, vi } from "vitest";
import { createLinearCloseoutService } from "./linearCloseoutService";
import { createLinearIngressService } from "./linearIngressService";
import { createLinearIntakeService } from "./linearIntakeService";
import { createLinearRoutingService } from "./linearRoutingService";
import { describe, expect, it } from "vitest";
import { describe, expect, it, vi } from "vitest";
import { openKvDb } from "../state/kvDb";

describe("linearIntakeService (file group)", () => {
Expand Down
12 changes: 6 additions & 6 deletions apps/desktop/src/main/services/cto/linearSync.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import type { LinearSyncConfig } from "../../../shared/types";
import type { LinearWorkflowConfig, LinearWorkflowMatchResult, NormalizedLinearIssue } from "../../../shared/types";
import type { LinearWorkflowConfig, NormalizedLinearIssue } from "../../../shared/types";
import type { NormalizedLinearIssue } from "../../../shared/types";
import type {
LinearSyncConfig,
LinearWorkflowConfig,
LinearWorkflowMatchResult,
NormalizedLinearIssue,
} from "../../../shared/types";
import { afterEach, describe, expect, it, vi } from "vitest";
import { createLinearCloseoutService } from "./linearCloseoutService";
import { createLinearDispatcherService } from "./linearDispatcherService";
import { createLinearOutboundService } from "./linearOutboundService";
import { createLinearSyncService } from "./linearSyncService";
import { createLinearTemplateService } from "./linearTemplateService";
import { createLinearWorkflowFileService } from "./linearWorkflowFileService";
import { describe, expect, it } from "vitest";
import { describe, expect, it, vi } from "vitest";
import { openKvDb } from "../state/kvDb";
import { pathToFileURL } from "node:url";

Expand Down
13 changes: 9 additions & 4 deletions apps/desktop/src/main/services/prs/prRebase.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { afterAll, beforeAll, describe, expect, it, vi } from "vitest";
import type { LaneSummary, RebaseNeed } from "../../../shared/types";
import type {
AgentChatPermissionMode,
AiPermissionMode,
LaneSummary,
RebaseNeed,
} from "../../../shared/types";

// ---------------------------------------------------------------------------
// Module mocks
Expand Down Expand Up @@ -56,11 +61,11 @@ const mockRunGit = vi.mocked(runGit);
describe("resolverUtils (real module)", () => {
// Lazy-loaded handles to the real module so the prRebaseResolver mock above
// does not interfere.
let mapPermissionMode: (mode: string | undefined) => string;
let mapPermissionMode: (mode: AiPermissionMode | undefined) => AgentChatPermissionMode;
let mapPermissionModeForModelFamily: (
mode: string | undefined,
mode: AiPermissionMode | undefined,
family: string | undefined,
) => string;
) => AgentChatPermissionMode;
let readRecentCommits: (worktreePath: string, count?: number, ref?: string) => Promise<Array<{ sha: string; subject: string }>>;

beforeAll(async () => {
Expand Down
Loading