Skip to content

Update Claude agent runtime surfaces #287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arul28 merged 3 commits into from
May 12, 2026
Merged

Update Claude agent runtime surfaces #287

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a92be4f
ship: update Claude agent runtime surfaces
arul28 May 12, 2026
03e46d5
fix: classify cwd Claude output styles as project
arul28 May 12, 2026
1dd5c3a
fix: keep packaged Claude native runtime
arul28 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<img src="assets/readme/hero-iphone.png" alt="ADE on iOS" width="180" />
</p>

ADE runs **Claude Code, Codex, Cursor, opencode** — every major AI coding agent — inside one native workspace. Every task is its own git worktree, so agents ship features in parallel. Review and merge PRs in-app. Approve a diff from your phone while another agent tests on your Mac.
ADE runs **Claude Code, Codex, Cursor, opencode** — every major AI coding agent — inside one native workspace. Claude runs through the bundled Claude Agent SDK, while desktop and `ade code` share the same lane-scoped chat runtime. Every task is its own git worktree, so agents ship features in parallel. Review and merge PRs in-app. Approve a diff from your phone while another agent tests on your Mac.

Free, open source, local-first. Bring your own keys or subs.

Expand Down
144 changes: 72 additions & 72 deletions apps/ade-cli/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion apps/ade-cli/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
},
"dependencies": {
"@agentclientprotocol/sdk": "^0.20.0",
"@anthropic-ai/claude-agent-sdk": "^0.2.119",
"@anthropic-ai/claude-agent-sdk": "^0.2.139",
"@cursor/sdk": "^1.0.9",
"@linear/sdk": "^84.0.0",
"@opencode-ai/sdk": "^1.4.2",
Expand Down
5 changes: 4 additions & 1 deletion apps/ade-cli/src/adeRpcServer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,10 @@ function createRuntime() {
getStatus: vi.fn(async () => ({
mode: "subscription",
availableProviders: {
claude: true,
claude: {
binary: { present: true, source: "path", path: "/usr/local/bin/claude" },
auth: { ready: true, mode: "oauth", detail: null },
},
codex: true,
cursor: false,
droid: false,
Expand Down
10 changes: 6 additions & 4 deletions apps/ade-cli/src/services/sync/syncRemoteCommandService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,11 @@ async function summarizeChatSessionForRemote(
reasoningEffort: session.reasoningEffort ?? null,
codexFastMode: session.codexFastMode === true,
executionMode: session.executionMode ?? null,
...(session.permissionMode ? { permissionMode: session.permissionMode } : {}),
...(session.interactionMode !== undefined ? { interactionMode: session.interactionMode } : {}),
...(session.claudePermissionMode ? { claudePermissionMode: session.claudePermissionMode } : {}),
...(session.codexApprovalPolicy ? { codexApprovalPolicy: session.codexApprovalPolicy } : {}),
...(session.permissionMode ? { permissionMode: session.permissionMode } : {}),
...(session.interactionMode !== undefined ? { interactionMode: session.interactionMode } : {}),
...(session.claudePermissionMode ? { claudePermissionMode: session.claudePermissionMode } : {}),
...(session.claudeOutputStyle ? { claudeOutputStyle: session.claudeOutputStyle } : {}),
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Preserve explicit null for claudeOutputStyle in fallback summaries.

At Line 307, the truthy check omits claudeOutputStyle when it is explicitly null, which can drift from the nullable contract shape used by create args and shared types.

Suggested fix 
-    ...(session.claudeOutputStyle ? { claudeOutputStyle: session.claudeOutputStyle } : {}),
+    ...(session.claudeOutputStyle !== undefined ? { claudeOutputStyle: session.claudeOutputStyle } : {}),

As per coding guidelines, "Keep IPC contracts, preload types, shared types, and renderer usage in sync whenever an interface changes in TypeScript".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
...(session.claudeOutputStyle ? { claudeOutputStyle: session.claudeOutputStyle } : {}),
...(session.claudeOutputStyle !== undefined ? { claudeOutputStyle: session.claudeOutputStyle } : {}),
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@apps/ade-cli/src/services/sync/syncRemoteCommandService.ts` at line 307, The
spread currently omits claudeOutputStyle when it's explicitly null because it
uses a truthy check; change the conditional to include the property whenever it
exists (including null) by checking for undefined rather than falsiness. Replace
the spread ...(session.claudeOutputStyle ? { claudeOutputStyle:
session.claudeOutputStyle } : {}) with a check like
...(session.claudeOutputStyle !== undefined ? { claudeOutputStyle:
session.claudeOutputStyle } : {}) (or use
Object.prototype.hasOwnProperty.call(session, 'claudeOutputStyle')) in the code
that builds the fallback summary payload in syncRemoteCommandService / the
function that constructs the create args so the nullable contract is preserved.

...(session.codexApprovalPolicy ? { codexApprovalPolicy: session.codexApprovalPolicy } : {}),
Copy link
Copy Markdown

@cursor cursor Bot May 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed tab and space indentation in session summary

Low Severity

Lines 304–308 use hard-tab indentation (\t) while the rest of the file and surrounding lines use spaces. This inconsistency was introduced when the claudeOutputStyle spread was added between the existing claudePermissionMode and codexApprovalPolicy lines.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 03e46d5. Configure here.

...(session.codexSandbox ? { codexSandbox: session.codexSandbox } : {}),
...(session.codexConfigSource ? { codexConfigSource: session.codexConfigSource } : {}),
...(session.opencodePermissionMode ? { opencodePermissionMode: session.opencodePermissionMode } : {}),
Expand Down Expand Up @@ -621,6 +622,7 @@ function parseAgentChatCreateArgs(value: Record<string, unknown>): AgentChatCrea
if ("permissionMode" in value) parsed.permissionMode = value.permissionMode == null ? undefined : asTrimmedString(value.permissionMode) as AgentChatCreateArgs["permissionMode"];
if ("interactionMode" in value) parsed.interactionMode = value.interactionMode == null ? null : asTrimmedString(value.interactionMode) as AgentChatCreateArgs["interactionMode"];
if ("claudePermissionMode" in value) parsed.claudePermissionMode = value.claudePermissionMode == null ? undefined : asTrimmedString(value.claudePermissionMode) as AgentChatCreateArgs["claudePermissionMode"];
if ("claudeOutputStyle" in value) parsed.claudeOutputStyle = value.claudeOutputStyle == null ? null : asTrimmedString(value.claudeOutputStyle) ?? null;
if ("codexApprovalPolicy" in value) parsed.codexApprovalPolicy = value.codexApprovalPolicy == null ? undefined : asTrimmedString(value.codexApprovalPolicy) as AgentChatCreateArgs["codexApprovalPolicy"];
if ("codexSandbox" in value) parsed.codexSandbox = value.codexSandbox == null ? undefined : asTrimmedString(value.codexSandbox) as AgentChatCreateArgs["codexSandbox"];
if ("codexConfigSource" in value) parsed.codexConfigSource = value.codexConfigSource == null ? undefined : asTrimmedString(value.codexConfigSource) as AgentChatCreateArgs["codexConfigSource"];
Expand Down
24 changes: 24 additions & 0 deletions apps/ade-cli/src/tuiClient/__tests__/RightPane.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,3 +89,27 @@ describe("RightPane model-setup", () => {
expect(frame).toMatch(/◇ Codex.*active/);
});
});

describe("RightPane subagents", () => {
it("renders subagent tabs and active rows", () => {
const frame = render(
<RightPane
content={{
kind: "subagents",
tab: "subagents",
snapshots: [
{ id: "a1", name: "research-explorer", kind: "subagent", status: "running", summary: "checking files", tokens: 2300, durationMs: 14000 },
{ id: "b1", name: "reviewer", kind: "background", status: "completed", summary: "done" },
],
}}
focused
/>,
).lastFrame() ?? "";

expect(frame).toContain("[Subagents]");
expect(frame).toContain("Teammates");
expect(frame).toContain("Background");
expect(frame).toContain("research-explorer");
expect(frame).not.toContain("reviewer");
});
});
Loading
Loading