Conversation
das-Abroxas
approved these changes
Apr 6, 2023
Contributor
das-Abroxas
left a comment
das-Abroxas
left a comment
There was a problem hiding this comment.
User deactivation is important, of course. Why didn't we have this before?...
And an e-mail address is very useful to distribute information directly to users. But in the future we have to be even more careful about the privacy of user information.
But all in all useful and sensible additions to the API, which especially make life easier for administrators 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes some nice QOL API features for user handling , especially for admin user handling and the WebUI:
Changes:
emailstoregister_userrequest in preparation for email notifications (as well as a user-provided optional project hint)deactivate_userrequest (tracked in Tasklist for 1.0.0 Changes #55)get_all_usersrequest for adminsactivate_userand automatically add them to a project.This should not contain any breaking changes only add additional functionality to existing APIs.