Skip to content

Basic notification and search functionality#100

Merged
das-Abroxas merged 43 commits intofeat/version2.0reworkfrom
feat/search
Aug 9, 2023
Merged

Basic notification and search functionality#100
das-Abroxas merged 43 commits intofeat/version2.0reworkfrom
feat/search

Conversation

@das-Abroxas
Copy link
Copy Markdown
Contributor

This implements the basis for the AOS notification and search functionality.

The notifications are used internally to communicate updates between specific AOS components and can also be used by external users to keep track on resource modifications. The search function allows external users to search the metadata of all public/private resources in the AOS index for freely selected keywords. Specific fields will also be filterable in the future so that the search can be narrowed down individually.

Features:

  • Object hierarchy traversal available
  • Notification emission for resources, users and announcements available
  • Basic resource metadata search implemented

ToDo:

  • Add notification emission to all involved middlelayer functions
  • Implement ArunaServer notification handling
  • Add search index update to all involved gRPC functions
  • Agree on which fields can be filtered in the search index

das-Abroxas and others added 30 commits July 27, 2023 10:25
Wit this enum it is now possible to map any value to the types an
Object can represent.
@das-Abroxas das-Abroxas added the enhancement New feature or request label Aug 9, 2023
@das-Abroxas das-Abroxas self-assigned this Aug 9, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 9, 2023

Codecov Report

Patch coverage: 44.45% and project coverage change: +6.75% 🎉

Comparison is base (e1ec149) 20.42% compared to head (1d408c4) 27.17%.
Report is 1 commits behind head on feat/version2.0rework.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #100      +/-   ##
=========================================================
+ Coverage                  20.42%   27.17%   +6.75%     
=========================================================
  Files                         51       54       +3     
  Lines                       4549     5395     +846     
=========================================================
+ Hits                         929     1466     +537     
- Misses                      3620     3929     +309     
Files Changed Coverage Δ
src/auth/structs.rs 0.00% <0.00%> (ø)
src/database/dsls/internal_relation_dsl.rs 52.08% <0.00%> (ø)
src/database/dsls/user_dsl.rs 53.19% <0.00%> (ø)
src/grpc/notification.rs 0.00% <0.00%> (ø)
src/grpc/projects.rs 0.00% <0.00%> (ø)
src/grpc/search.rs 0.00% <0.00%> (ø)
src/lib.rs 64.23% <ø> (+0.02%) ⬆️
src/middlelayer/create_db_handler.rs 0.00% <0.00%> (ø)
src/middlelayer/relations_request_types.rs 0.00% <0.00%> (ø)
src/search/meilisearch_client.rs 0.00% <0.00%> (ø)
... and 8 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@das-Abroxas das-Abroxas requested review from St4NNi and lfbrehm August 9, 2023 08:57
Copy link
Copy Markdown
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Way too much for a proper review.
But in a first glance it looks good,
nice additions with nats and meili !

@das-Abroxas das-Abroxas merged commit 96d3a15 into feat/version2.0rework Aug 9, 2023
@St4NNi St4NNi deleted the feat/search branch August 29, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants