Skip to content

Feat/version2.0 hierarchy#102

Merged
lfbrehm merged 8 commits intofeat/version2.0reworkfrom
feat/version2.0_hierarchy
Aug 16, 2023
Merged

Feat/version2.0 hierarchy#102
lfbrehm merged 8 commits intofeat/version2.0reworkfrom
feat/version2.0_hierarchy

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Aug 14, 2023

This adds the missing GetHierarchy gRPC request, missing middlelayer tests and some bugfixes discovered while testing.

@lfbrehm lfbrehm requested review from St4NNi and das-Abroxas August 14, 2023 12:27
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 14, 2023

Codecov Report

Patch coverage: 50.68% and project coverage change: +7.02% 🎉

Comparison is base (68c3125) 36.63% compared to head (a875f46) 43.65%.
Report is 1 commits behind head on feat/version2.0rework.

❗ Current head a875f46 differs from pull request most recent head 745d6c7. Consider uploading reports for the commit 745d6c7 to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #102      +/-   ##
=========================================================
+ Coverage                  36.63%   43.65%   +7.02%     
=========================================================
  Files                         56       57       +1     
  Lines                       5713     5818     +105     
=========================================================
+ Hits                        2093     2540     +447     
+ Misses                      3620     3278     -342     
Files Changed Coverage Δ
src/caching/cache.rs 68.20% <0.00%> (-2.24%) ⬇️
src/grpc/relations.rs 0.00% <0.00%> (ø)
src/middlelayer/clone_request_types.rs 0.00% <0.00%> (ø)
src/utils/cache_utils.rs 0.00% <0.00%> (ø)
src/utils/grpc_utils.rs 26.25% <0.00%> (ø)
src/middlelayer/update_db_handler.rs 95.55% <94.73%> (+95.55%) ⬆️
src/middlelayer/relations_db_handler.rs 87.80% <100.00%> (ø)
src/middlelayer/snapshot_db_handler.rs 100.00% <100.00%> (+16.66%) ⬆️
src/middlelayer/snapshot_request_types.rs 88.20% <100.00%> (+32.48%) ⬆️
src/middlelayer/update_request_types.rs 93.57% <100.00%> (+93.57%) ⬆️
... and 1 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small note on style. Apart from that, I didn't notice anything obvious. Approved ✌️

Comment thread src/utils/cache_utils.rs Outdated
let origin = input.object.id;
let mut dataset_children: Vec<DatasetRelations> = Vec::new();
let object_children = get_object_children(input);
for d in input
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please not name variables with a single character? It won't break anyone's neck, but it will make it unnecessarily more difficult for later when you have to touch the code again for some reason. I have already seen this in the PR in several places.

@lfbrehm lfbrehm merged commit d26ede3 into feat/version2.0rework Aug 16, 2023
@St4NNi St4NNi deleted the feat/version2.0_hierarchy branch August 29, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants