Feat/version2.0 hierarchy#102
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/version2.0rework #102 +/- ##
=========================================================
+ Coverage 36.63% 43.65% +7.02%
=========================================================
Files 56 57 +1
Lines 5713 5818 +105
=========================================================
+ Hits 2093 2540 +447
+ Misses 3620 3278 -342
☔ View full report in Codecov by Sentry. |
das-Abroxas
left a comment
There was a problem hiding this comment.
Just a small note on style. Apart from that, I didn't notice anything obvious. Approved ✌️
| let origin = input.object.id; | ||
| let mut dataset_children: Vec<DatasetRelations> = Vec::new(); | ||
| let object_children = get_object_children(input); | ||
| for d in input |
There was a problem hiding this comment.
Can we please not name variables with a single character? It won't break anyone's neck, but it will make it unnecessarily more difficult for later when you have to touch the code again for some reason. I have already seen this in the PR in several places.
This adds the missing
GetHierarchygRPC request, missing middlelayer tests and some bugfixes discovered while testing.