Skip to content

Feat/version2.0 creation fixes#110

Merged
St4NNi merged 3 commits intofeat/version2.0reworkfrom
feat/version2.0_creation_fixes
Aug 23, 2023
Merged

Feat/version2.0 creation fixes#110
St4NNi merged 3 commits intofeat/version2.0reworkfrom
feat/version2.0_creation_fixes

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Aug 23, 2023

  • Adds FinishObjectStaging gRPC request
  • Fixes unique constraint matching for create-requests
  • Checks if user-specified endpoints exist for create-requests
  • Adds tests for endpoints in tests/middlelayer/create.rs

@lfbrehm lfbrehm requested review from St4NNi and das-Abroxas August 23, 2023 11:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2023

Codecov Report

Patch coverage: 30.98% and project coverage change: +0.21% 🎉

Comparison is base (3955ba6) 37.73% compared to head (b5f9095) 37.95%.
Report is 79 commits behind head on feat/version2.0rework.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #110      +/-   ##
=========================================================
+ Coverage                  37.73%   37.95%   +0.21%     
=========================================================
  Files                         59       60       +1     
  Lines                       6741     7556     +815     
=========================================================
+ Hits                        2544     2868     +324     
- Misses                      4197     4688     +491     
Files Changed Coverage Δ
src/auth/permission_handler.rs 0.00% <0.00%> (ø)
src/auth/structs.rs 7.27% <0.00%> (ø)
src/auth/token_handler.rs 0.00% <0.00%> (ø)
src/caching/notifications_handler.rs 0.00% <0.00%> (ø)
src/caching/structs.rs 27.58% <0.00%> (-45.15%) ⬇️
src/database/crud.rs 0.00% <ø> (ø)
src/database/dsls/external_user_id_dsl.rs 0.00% <0.00%> (ø)
src/database/dsls/identity_provider_dsl.rs 0.00% <0.00%> (ø)
src/database/dsls/mod.rs 0.00% <ø> (ø)
src/database/dsls/relation_type_dsl.rs 0.00% <0.00%> (ø)
... and 39 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@St4NNi St4NNi merged commit 0a3d2a8 into feat/version2.0rework Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants