Skip to content

Implement AuthorizationService#111

Merged
das-Abroxas merged 5 commits intofeat/version2.0reworkfrom
feat/AuthorizationService
Aug 23, 2023
Merged

Implement AuthorizationService#111
das-Abroxas merged 5 commits intofeat/version2.0reworkfrom
feat/AuthorizationService

Conversation

@das-Abroxas
Copy link
Copy Markdown
Contributor

This implements the missing gRPC functions of the AuthorizationService.

Features:

  • Permissions on resources can now get fetched, removed and updated
  • After many tries Clippy convinced me to implement the Default trait for Cache

@das-Abroxas das-Abroxas added the enhancement New feature or request label Aug 23, 2023
@das-Abroxas das-Abroxas requested review from St4NNi and lfbrehm August 23, 2023 15:51
@das-Abroxas das-Abroxas self-assigned this Aug 23, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 23, 2023

Codecov Report

Patch coverage: 36.55% and project coverage change: +0.15% 🎉

Comparison is base (b5f9095) 37.95% compared to head (061988b) 38.11%.
Report is 13 commits behind head on feat/version2.0rework.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #111      +/-   ##
=========================================================
+ Coverage                  37.95%   38.11%   +0.15%     
=========================================================
  Files                         60       60              
  Lines                       7556     7792     +236     
=========================================================
+ Hits                        2868     2970     +102     
- Misses                      4688     4822     +134     
Files Changed Coverage Δ
src/auth/permission_handler.rs 0.00% <0.00%> (ø)
src/auth/token_handler.rs 0.00% <0.00%> (ø)
src/caching/notifications_handler.rs 0.00% <0.00%> (ø)
src/caching/structs.rs 15.38% <0.00%> (-12.21%) ⬇️
src/grpc/authorization.rs 0.00% <0.00%> (ø)
src/grpc/notification.rs 0.00% <0.00%> (ø)
src/grpc/object.rs 0.00% <0.00%> (ø)
src/main.rs 0.68% <0.00%> (-0.03%) ⬇️
src/middlelayer/create_db_handler.rs 72.00% <0.00%> (-6.27%) ⬇️
src/middlelayer/user_db_handler.rs 45.96% <0.00%> (-10.97%) ⬇️
... and 8 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@lfbrehm lfbrehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it LGTM ...really sure !

@das-Abroxas das-Abroxas merged commit 442336f into feat/version2.0rework Aug 23, 2023
@St4NNi St4NNi deleted the feat/AuthorizationService branch August 29, 2023 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants