Add tests for gRPC ProjectService#113
Merged
das-Abroxas merged 14 commits intofeat/version2.0reworkfrom Aug 25, 2023
Merged
Conversation
Adds init functions for all ArunaServer components analog to the startup initialization process. These can be used to emulate the individual service implementations in the testing environment.
The query still has selected from the outdated object table and not from the updated values.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/version2.0rework #113 +/- ##
=========================================================
+ Coverage 40.53% 46.82% +6.29%
=========================================================
Files 60 60
Lines 7636 7643 +7
=========================================================
+ Hits 3095 3579 +484
+ Misses 4541 4064 -477
☔ View full report in Codecov by Sentry. |
lfbrehm
approved these changes
Aug 25, 2023
Member
lfbrehm
left a comment
lfbrehm
left a comment
There was a problem hiding this comment.
This is looks good to me so far.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This creates a basic set of tests for the ProjectService.
For this purpose, the corresponding init functions of all modules were created in the test utils, which are also used in the normal start-up process of the ArunaServer. This means that every ArunaAPI service implemented in the ArunaServer can now be emulated in the tests.
Added Tests:
ToDo:
For the future, a concept should also be developed on how to additionally detect side effects in the tests. So far, the functionalities are only considered in isolation, but could potentially influence/modify other data in case of implementation errors.