Skip to content

Feat/version2.0rework generate urls#115

Merged
lfbrehm merged 10 commits intofeat/version2.0reworkfrom
feat/version2.0rework_generate_urls
Aug 30, 2023
Merged

Feat/version2.0rework generate urls#115
lfbrehm merged 10 commits intofeat/version2.0reworkfrom
feat/version2.0rework_generate_urls

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Aug 29, 2023

Feat

  • Implements gRPC requests for GetDownloadUrl and GetUploadUrl

Fix

  • HostConfig for endpoints have changed DataProxyFeatures to differentiate between S3 and gRPC interfaces of data proxies

ToDO

  • API must be changed to address changed DataProxyFeatures

@lfbrehm lfbrehm requested a review from St4NNi August 29, 2023 12:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 29, 2023

Codecov Report

Patch coverage: 0.57% and project coverage change: -1.93% ⚠️

Comparison is base (4d9ede6) 46.82% compared to head (bd37417) 44.90%.
Report is 1 commits behind head on feat/version2.0rework.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #115      +/-   ##
=========================================================
- Coverage                  46.82%   44.90%   -1.93%     
=========================================================
  Files                         60       61       +1     
  Lines                       7643     7997     +354     
=========================================================
+ Hits                        3579     3591      +12     
- Misses                      4064     4406     +342     
Files Changed Coverage Δ
src/caching/notifications_handler.rs 0.00% <0.00%> (ø)
src/caching/structs.rs 23.18% <0.00%> (-7.59%) ⬇️
src/database/enums.rs 68.47% <0.00%> (ø)
src/grpc/authorization.rs 0.00% <0.00%> (ø)
src/grpc/endpoints.rs 0.00% <0.00%> (ø)
src/grpc/info.rs 0.00% <ø> (ø)
src/grpc/notification.rs 0.00% <0.00%> (ø)
src/grpc/object.rs 0.00% <0.00%> (ø)
src/grpc/users.rs 0.00% <0.00%> (ø)
src/middlelayer/presigned_url_handler.rs 0.00% <0.00%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments

Comment thread tests/common/initial_data.sql
@lfbrehm lfbrehm merged commit c405ca7 into feat/version2.0rework Aug 30, 2023
@St4NNi St4NNi deleted the feat/version2.0rework_generate_urls branch September 20, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants