Add message deduplication#116
Merged
das-Abroxas merged 3 commits intofeat/version2.0reworkfrom Sep 19, 2023
Merged
Conversation
St4NNi
approved these changes
Sep 19, 2023
Member
St4NNi
left a comment
St4NNi
left a comment
There was a problem hiding this comment.
This should work for now and be the best option.
We might revisit this in the future if it will not work as expected.
LGTM!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/version2.0rework #116 +/- ##
=========================================================
+ Coverage 44.97% 45.16% +0.18%
=========================================================
Files 61 61
Lines 8117 8177 +60
=========================================================
+ Hits 3651 3693 +42
- Misses 4466 4484 +18
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds message deduplication to the integrated notification concept.
Since the hierarchy concept allows the same notification to be sent to a consumer multiple times, it is beneficial to perform internal deduplication.
If a notification with the same content is sent for several hierarchies of a resource, these notifications are provided with the same ULID in their header (
"block-id": ULID). This ULID is used to re-identify the message blocks that belong together when a consumer retrieves several of them.This ensures that each notification within a particular action in the AOS is only delivered once to the user.