Feat/v2 hooks#118
Merged
lfbrehm merged 26 commits intofeat/version2.0reworkfrom Sep 22, 2023
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/version2.0rework #118 +/- ##
=========================================================
- Coverage 45.16% 41.51% -3.65%
=========================================================
Files 61 66 +5
Lines 8177 9380 +1203
=========================================================
+ Hits 3693 3894 +201
- Misses 4484 5486 +1002
☔ View full report in Codecov by Sentry. |
das-Abroxas
approved these changes
Sep 22, 2023
Contributor
das-Abroxas
left a comment
das-Abroxas
left a comment
There was a problem hiding this comment.
The future will show whether the implementation details have gaps or not. Approved by my side but occurring errors will be fixed by the author 🙂
St4NNi
reviewed
Sep 22, 2023
| } | ||
| // Check if object metadata is publicly available | ||
| match object_plus.object.data_class { | ||
| DataClass::PUBLIC => {} |
Member
There was a problem hiding this comment.
Private objects should get (redacted) infos as well. So it was correct before, but ultimately we should tie this to the "Metadata" License.
|
|
||
| // Check if object metadata is publicly available | ||
| match object_plus.object.data_class { | ||
| DataClass::PUBLIC => {} |
Member
There was a problem hiding this comment.
Same as in get_resource, unclear if this is correct permission wise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hooks
This PR adds rudimentary Hook triggers and includes drafts for further Hook functionality.
Fixes
Some syncing issues between DB and cache are fixed