Skip to content

CollectionService/DatasetService tests#119

Merged
das-Abroxas merged 16 commits intofeat/version2.0reworkfrom
test/grpc-tests
Sep 25, 2023
Merged

CollectionService/DatasetService tests#119
das-Abroxas merged 16 commits intofeat/version2.0reworkfrom
test/grpc-tests

Conversation

@das-Abroxas
Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas commented Sep 22, 2023

Features

This adds tests for the CollectionService / DatasetService function implementations:

  • create_collection / dataset
  • get_collection / dataset
  • get_collections / datasets
  • delete_collection / dataset
  • update_collection_name / dataset_name
  • update_collection_description / dataset_description
  • update_collection_key_values / dataset_key_values
  • update_collection_data_class / dataset_data_class
  • snapshot_collection /dataset

@das-Abroxas das-Abroxas self-assigned this Sep 22, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 22, 2023

Codecov Report

Patch coverage: 57.89% and project coverage change: +3.27% 🎉

Comparison is base (6e88245) 41.51% compared to head (566f2b2) 44.78%.
Report is 3 commits behind head on feat/version2.0rework.

❗ Current head 566f2b2 differs from pull request most recent head 288c556. Consider uploading reports for the commit 288c556 to get more accurate results

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #119      +/-   ##
=========================================================
+ Coverage                  41.51%   44.78%   +3.27%     
=========================================================
  Files                         66       66              
  Lines                       9380     9384       +4     
=========================================================
+ Hits                        3894     4203     +309     
+ Misses                      5486     5181     -305     
Files Changed Coverage Δ
src/caching/notifications_handler.rs 0.00% <0.00%> (ø)
src/grpc/datasets.rs 0.00% <0.00%> (ø)
src/grpc/object.rs 0.00% <0.00%> (ø)
src/grpc/relations.rs 0.00% <0.00%> (ø)
src/grpc/workspaces.rs 0.00% <0.00%> (ø)
src/middlelayer/hooks_db_handler.rs 22.18% <0.00%> (+1.50%) ⬆️
src/middlelayer/hooks_request_types.rs 0.00% <0.00%> (ø)
src/middlelayer/token_db_handler.rs 0.00% <0.00%> (ø)
src/caching/cache.rs 72.36% <100.00%> (+0.22%) ⬆️
src/database/dsls/object_dsl.rs 85.44% <100.00%> (+0.80%) ⬆️
... and 7 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@das-Abroxas das-Abroxas changed the title CollectionService tests CollectionService/DatasetService tests Sep 25, 2023
@das-Abroxas das-Abroxas merged commit 736e39f into feat/version2.0rework Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants