Feat/v2 workspaces#122
Merged
St4NNi merged 11 commits intofeat/version2.0reworkfrom Sep 28, 2023
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## feat/version2.0rework #122 +/- ##
=========================================================
- Coverage 47.71% 46.74% -0.97%
=========================================================
Files 69 69
Lines 9753 10028 +275
=========================================================
+ Hits 4654 4688 +34
- Misses 5099 5340 +241
☔ View full report in Codecov by Sentry. |
das-Abroxas
approved these changes
Sep 28, 2023
Contributor
das-Abroxas
left a comment
das-Abroxas
left a comment
There was a problem hiding this comment.
Two comments that can be addressed before merge.
| client: &Client, | ||
| ) -> Result<()> { | ||
| let query = "UPDATE objects | ||
| SET data_class = ('CONFIDENTIAL'), created_by = $1 |
Contributor
There was a problem hiding this comment.
But the claimed objects do not meet the requirements for our definition of the data class 'Confidential'?
Member
Author
There was a problem hiding this comment.
You're right, this should be set to PRIVATE.
Comment on lines
+211
to
+227
| let client = tonic_internal!( | ||
| self.database_handler.database.get_client().await, | ||
| "Internal database error" | ||
| ); | ||
| let hook = tonic_invalid!( | ||
| Hook::get(request.hook_id.clone(), &client).await, | ||
| "Hook not found" | ||
| ) | ||
| .ok_or_else(|| tonic::Status::not_found("Hook not found"))?; | ||
|
|
||
| if user != hook.owner { | ||
| return Err(tonic::Status::unauthenticated("Access not allowed")); | ||
| } | ||
| tonic_internal!( | ||
| self.database_handler.append_project_to_hook(request).await, | ||
| "HookCallback failed" | ||
| ); |
Contributor
There was a problem hiding this comment.
This could be moved into the middlelayer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspaces
Hooks
General