Skip to content

Feat/v2 workspaces#125

Merged
lfbrehm merged 9 commits intofeat/version2.0reworkfrom
feat/v2_workspaces
Oct 13, 2023
Merged

Feat/v2 workspaces#125
lfbrehm merged 9 commits intofeat/version2.0reworkfrom
feat/v2_workspaces

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Oct 12, 2023

This PR fixes a workspace related SQL query, adds some testing and fixes the Dockerfile.

@lfbrehm lfbrehm requested review from St4NNi and das-Abroxas October 12, 2023 11:50
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 12, 2023

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (029d2e0) 46.74% compared to head (1ba32d0) 52.49%.
Report is 26 commits behind head on feat/version2.0rework.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #125      +/-   ##
=========================================================
+ Coverage                  46.74%   52.49%   +5.74%     
=========================================================
  Files                         69       70       +1     
  Lines                      10028    10286     +258     
=========================================================
+ Hits                        4688     5400     +712     
+ Misses                      5340     4886     -454     
Files Coverage Δ
src/database/dsls/mod.rs 100.00% <ø> (ø)
src/database/enums.rs 78.12% <100.00%> (+2.03%) ⬆️
src/grpc/authorization.rs 97.24% <100.00%> (+0.02%) ⬆️
src/grpc/hooks.rs 0.00% <ø> (ø)
src/grpc/search.rs 11.72% <100.00%> (+11.72%) ⬆️
src/grpc/workspaces.rs 0.00% <ø> (ø)
src/middlelayer/create_db_handler.rs 73.45% <100.00%> (+0.23%) ⬆️
src/middlelayer/token_db_handler.rs 29.11% <100.00%> (+29.11%) ⬆️
src/middlelayer/workspace_db_handler.rs 92.26% <100.00%> (+92.26%) ⬆️
src/main.rs 0.66% <0.00%> (-0.01%) ⬇️
... and 7 more

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@lfbrehm lfbrehm merged commit c4a8e4f into feat/version2.0rework Oct 13, 2023
@lfbrehm lfbrehm deleted the feat/v2_workspaces branch October 13, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants