Skip to content

Feat/v2 workspaces#126

Merged
das-Abroxas merged 4 commits intofeat/version2.0reworkfrom
feat/v2_workspaces
Oct 13, 2023
Merged

Feat/v2 workspaces#126
das-Abroxas merged 4 commits intofeat/version2.0reworkfrom
feat/v2_workspaces

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Oct 13, 2023

This PR fixes:

  • Permission bugs in get_resource() and get_resources()
  • Search filter bug where indexed objects get filtered by object_type instead of data_class
  • Mock endpoints called in test/middlelayer/workflows.rs

@lfbrehm lfbrehm requested review from St4NNi and das-Abroxas October 13, 2023 16:00
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 13, 2023

Codecov Report

Attention: 54 lines in your changes are missing coverage. Please review.

Comparison is base (1ba32d0) 52.49% compared to head (1b4de44) 52.49%.
Report is 1 commits behind head on feat/version2.0rework.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           feat/version2.0rework     #126      +/-   ##
=========================================================
- Coverage                  52.49%   52.49%   -0.01%     
=========================================================
  Files                         70       70              
  Lines                      10286    10320      +34     
=========================================================
+ Hits                        5400     5417      +17     
- Misses                      4886     4903      +17     
Files Coverage Δ
src/main.rs 0.67% <ø> (+<0.01%) ⬆️
src/search/meilisearch_client.rs 51.49% <0.00%> (+6.34%) ⬆️
src/utils/grpc_utils.rs 79.31% <75.00%> (-0.46%) ⬇️
src/grpc/search.rs 9.79% <0.00%> (-1.94%) ⬇️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice finds. Better stable, than sorry 👍

@das-Abroxas das-Abroxas added the enhancement New feature or request label Oct 13, 2023
@das-Abroxas das-Abroxas merged commit 882e118 into feat/version2.0rework Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants