Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #131 +/- ##
==========================================
+ Coverage 53.03% 53.17% +0.14%
==========================================
Files 73 73
Lines 10876 10982 +106
==========================================
+ Hits 5768 5840 +72
- Misses 5108 5142 +34
☔ View full report in Codecov by Sentry. |
das-Abroxas
approved these changes
Oct 30, 2023
Contributor
das-Abroxas
left a comment
das-Abroxas
left a comment
There was a problem hiding this comment.
Overall looks good to me.
| DataClass::PRIVATE => { | ||
| // TODO: Redacted object operations | ||
| // TODO: SPECIFIC private operations OTHER THAN strip labels | ||
| // -> maybe endpoint redaction? |
Contributor
There was a problem hiding this comment.
Also the field created_by could be emptied even if it is 'just' an id.
| DataClass::PRIVATE => { | ||
| //TODO: Redacted object | ||
| // TODO: SPECIFIC private operations OTHER THAN strip labels | ||
| // -> maybe endpoint redaction? |
St4NNi
reviewed
Oct 30, 2023
| impl Default for Context { | ||
| fn default() -> Self { | ||
| Self { | ||
| variant: ContextVariant::Activated, |
Member
There was a problem hiding this comment.
I think default should be activated and notactivated the "special" case.
Just to be sure that as a bare minimum the user is activated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains bug fixes for:
CreateHooksare now triggered on finish for objects