Skip to content

Feat/multiple OIDC provider#133

Merged
St4NNi merged 11 commits intodevfrom
feat/multiple_oidc_provider
Nov 15, 2023
Merged

Feat/multiple OIDC provider#133
St4NNi merged 11 commits intodevfrom
feat/multiple_oidc_provider

Conversation

@St4NNi
Copy link
Copy Markdown
Member

@St4NNi St4NNi commented Nov 15, 2023

Support for multiple OIDC providers

PR enabling support for more than one OIDC provider in parallel. This will make it easier to integrate different identity solutions into the system and bridge the gap to existing OIDC proxies and communities.

Changes

  • Removed external_id from user
  • Added OIDCMapping to Userattributes, this combines an external_id with an associated provider.
  • Added new identity_provider database table that stores the IP URL, an jwks endpoint and a list with allowed audiences
  • Unify issuer token checking with existing Dataproxy and Server TokenChecks including the potential for multiple different servers / dataproxies.
  • Enable audience checking for all tokens
  • Update API added add_oidc_provider and remove_oidc_provider functions for users to combine multiple provider for the same user

@St4NNi St4NNi requested a review from das-Abroxas November 15, 2023 19:53
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 15, 2023

Codecov Report

Attention: 949 lines in your changes are missing coverage. Please review.

Comparison is base (c2fe6e1) 53.17% compared to head (b32f399) 51.39%.
Report is 57 commits behind head on dev.

Files Patch % Lines
src/hooks/hook_handler.rs 2.29% 255 Missing ⚠️
src/grpc/service_account.rs 0.00% 60 Missing ⚠️
src/auth/issuer_handler.rs 42.15% 59 Missing ⚠️
src/grpc/users.rs 0.00% 58 Missing ⚠️
src/middlelayer/hooks_request_types.rs 0.00% 47 Missing ⚠️
src/utils/conversions.rs 45.97% 47 Missing ⚠️
src/middlelayer/user_db_handler.rs 28.57% 45 Missing ⚠️
src/main.rs 0.00% 35 Missing ⚠️
src/grpc/data_replication.rs 0.00% 30 Missing ⚠️
src/middlelayer/hooks_db_handler.rs 33.33% 30 Missing ⚠️
... and 29 more
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #133      +/-   ##
==========================================
- Coverage   53.17%   51.39%   -1.79%     
==========================================
  Files          73       78       +5     
  Lines       10982    11617     +635     
==========================================
+ Hits         5840     5970     +130     
- Misses       5142     5647     +505     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Another step in the right direction 🙂

@St4NNi St4NNi merged commit 3311edb into dev Nov 15, 2023
@St4NNi St4NNi deleted the feat/multiple_oidc_provider branch March 15, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants