Skip to content

fix: Fixed get_resource(s) permission handling#136

Merged
St4NNi merged 1 commit intodevfrom
fix/get_resource
Nov 20, 2023
Merged

fix: Fixed get_resource(s) permission handling#136
St4NNi merged 1 commit intodevfrom
fix/get_resource

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Nov 20, 2023

This PR fixes permission handling for get_resource and get_resources in grpc/search.rs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (f25d8e4) 51.63% compared to head (d81cd55) 52.72%.
Report is 10 commits behind head on dev.

Files Patch % Lines
src/auth/token_handler.rs 57.14% 3 Missing ⚠️
src/auth/permission_handler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #136      +/-   ##
==========================================
+ Coverage   51.63%   52.72%   +1.08%     
==========================================
  Files          78       78              
  Lines       11647    11629      -18     
==========================================
+ Hits         6014     6131     +117     
+ Misses       5633     5498     -135     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@St4NNi St4NNi merged commit b4e03b1 into dev Nov 20, 2023
@St4NNi St4NNi deleted the fix/get_resource branch November 20, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants