Skip to content

Feat/service accounts#137

Merged
St4NNi merged 4 commits intodevfrom
feat/service_accounts
Nov 21, 2023
Merged

Feat/service accounts#137
St4NNi merged 4 commits intodevfrom
feat/service_accounts

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Nov 21, 2023

In this PR all missing service account gRPC requests are implemented.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2023

Codecov Report

Attention: 585 lines in your changes are missing coverage. Please review.

Comparison is base (d81cd55) 52.72% compared to head (a34e03a) 50.28%.
Report is 10 commits behind head on dev.

Files Patch % Lines
src/grpc/service_account.rs 0.00% 212 Missing ⚠️
src/middlelayer/service_account_request_types.rs 0.00% 184 Missing ⚠️
src/middlelayer/service_accounts_db_handler.rs 0.00% 158 Missing ⚠️
src/utils/conversions.rs 0.00% 21 Missing ⚠️
src/utils/grpc_utils.rs 0.00% 7 Missing ⚠️
src/grpc/hooks.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #137      +/-   ##
==========================================
- Coverage   52.72%   50.28%   -2.44%     
==========================================
  Files          78       80       +2     
  Lines       11629    12199     +570     
==========================================
+ Hits         6131     6134       +3     
- Misses       5498     6065     +567     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@St4NNi St4NNi merged commit d9691b9 into dev Nov 21, 2023
@St4NNi St4NNi deleted the feat/service_accounts branch November 21, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants