Skip to content

Extended object deletion#138

Merged
St4NNi merged 12 commits intodevfrom
feat/object-deletion
Nov 22, 2023
Merged

Extended object deletion#138
St4NNi merged 12 commits intodevfrom
feat/object-deletion

Conversation

@das-Abroxas
Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas commented Nov 21, 2023

With this, resource deletion now works always recursive except for Objects which are by default the leafs of the hierarchy graph. For individual object deletion, the parameter with_revisions can be used to control whether all versions of an object should also be removed.

Deletion fails if:

  • A resource in the hierarchy has undeleted versions
  • A resource in the hierarchy has BELONGS_TO relations to resources outside the hierarchy which shall be deleted
  • An Object has undeleted versions together with the usage of with_revisions: false

Other changes

  • Resources with the status DELETED are excluded from search index full sync

@das-Abroxas das-Abroxas added enhancement New feature or request fix Bug issue fix labels Nov 21, 2023
@das-Abroxas das-Abroxas self-assigned this Nov 21, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 21, 2023

Codecov Report

Attention: 66 lines in your changes are missing coverage. Please review.

Comparison is base (a34e03a) 50.28% compared to head (f72fcaa) 50.54%.
Report is 11 commits behind head on dev.

❗ Current head f72fcaa differs from pull request most recent head aa143cc. Consider uploading reports for the commit aa143cc to get more accurate results

Files Patch % Lines
src/middlelayer/delete_db_handler.rs 71.64% 38 Missing ⚠️
src/grpc/endpoints.rs 0.00% 6 Missing ⚠️
src/auth/issuer_handler.rs 33.33% 4 Missing ⚠️
src/grpc/object.rs 0.00% 4 Missing ⚠️
src/utils/search_utils.rs 73.33% 4 Missing ⚠️
src/caching/cache.rs 0.00% 3 Missing ⚠️
src/utils/conversions.rs 25.00% 3 Missing ⚠️
src/caching/notifications_handler.rs 0.00% 2 Missing ⚠️
src/grpc/users.rs 0.00% 1 Missing ⚠️
src/middlelayer/presigned_url_handler.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #138      +/-   ##
==========================================
+ Coverage   50.28%   50.54%   +0.26%     
==========================================
  Files          80       80              
  Lines       12199    12368     +169     
==========================================
+ Hits         6134     6252     +118     
- Misses       6065     6116      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@St4NNi St4NNi merged commit 74d08c4 into dev Nov 22, 2023
@St4NNi St4NNi deleted the feat/object-deletion branch November 22, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fix Bug issue fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants