Skip to content

Feat/hook triggers#139

Merged
das-Abroxas merged 4 commits intodevfrom
feat/hook_triggers
Jan 4, 2024
Merged

Feat/hook triggers#139
das-Abroxas merged 4 commits intodevfrom
feat/hook_triggers

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Nov 27, 2023

This PR adds the last missing hook trigger HookStatusChanged and refactors permission handling for hook owners, so that their permissions are evaluated for any hook related action.

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 27, 2023

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (ab50e1a) 50.45% compared to head (f56715a) 50.51%.
Report is 2 commits behind head on dev.

Files Patch % Lines
src/hooks/hook_handler.rs 0.00% 18 Missing ⚠️
src/middlelayer/hooks_db_handler.rs 0.00% 15 Missing ⚠️
src/caching/cache.rs 54.54% 5 Missing ⚠️
src/grpc/object.rs 0.00% 2 Missing ⚠️
src/middlelayer/update_db_handler.rs 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #139      +/-   ##
==========================================
+ Coverage   50.45%   50.51%   +0.05%     
==========================================
  Files          81       81              
  Lines       12976    12997      +21     
==========================================
+ Hits         6547     6565      +18     
- Misses       6429     6432       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@das-Abroxas das-Abroxas merged commit c28887c into dev Jan 4, 2024
@St4NNi St4NNi deleted the feat/hook_triggers branch March 15, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants