Fix deleted resources permission handling#145
Merged
das-Abroxas merged 5 commits intodevfrom Jan 4, 2024
Merged
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #145 +/- ##
==========================================
+ Coverage 50.13% 50.45% +0.32%
==========================================
Files 81 81
Lines 12960 12976 +16
==========================================
+ Hits 6497 6547 +50
+ Misses 6463 6429 -34 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
Good work, lgtm! 🤝 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleted resources permission handling
Changes to the resource deletion concept had the unintended effect of removing deleted resources from permission handling. As a result, deleted resources could no longer be requested by users at all.
This PR fixes two bugs directly involved in the deletion handling process and resolves #142.