Skip to content

Fix/hooks#161

Merged
lfbrehm merged 5 commits intomainfrom
fix/hooks
Apr 23, 2024
Merged

Fix/hooks#161
lfbrehm merged 5 commits intomainfrom
fix/hooks

Conversation

@lfbrehm
Copy link
Copy Markdown
Member

@lfbrehm lfbrehm commented Apr 23, 2024

Summary

This is a hotfix for hook services

Changes

  • Adding labels in hook callbacks were overwritten by the old object state
  • JSON request parsing for hook services fixed
  • Retries for get_or_create_credentials because newly created tokens are not synced with proxies

@lfbrehm lfbrehm requested review from St4NNi and das-Abroxas April 23, 2024 10:25
das-Abroxas
das-Abroxas previously approved these changes Apr 23, 2024
Copy link
Copy Markdown
Contributor

@das-Abroxas das-Abroxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid to me 👍

Comment thread components/server/src/hooks/hook_handler.rs Outdated
Co-authored-by: Jannis Hochmuth <jannis.hochmuth@computational.bio.uni-giessen.de>
@lfbrehm lfbrehm merged commit 4daba9a into main Apr 23, 2024
@lfbrehm lfbrehm deleted the fix/hooks branch April 23, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants