Skip to content

Refactor public announcements#185

Merged
das-Abroxas merged 7 commits intomainfrom
feat/public-announcements
Jul 10, 2024
Merged

Refactor public announcements#185
das-Abroxas merged 7 commits intomainfrom
feat/public-announcements

Conversation

@das-Abroxas
Copy link
Copy Markdown
Contributor

This refactors parts of the public announcement implementation, especially regarding the creation and fetching of announcements.

Changes

  • Fetching now always returns the announcements sorted with newest first
  • Creation timestamp and the id are now tightly coupled to avoid breaking pagination
  • Announcements can be created with a specific timestamp which will be used for the id generation if the id is empty

@das-Abroxas das-Abroxas added enhancement New feature or request fix Bug issue fix labels Jul 9, 2024
@das-Abroxas das-Abroxas self-assigned this Jul 9, 2024
Copy link
Copy Markdown
Member

@St4NNi St4NNi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@das-Abroxas das-Abroxas merged commit daded5d into main Jul 10, 2024
@das-Abroxas das-Abroxas deleted the feat/public-announcements branch July 17, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request fix Bug issue fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants