Event notifications#87
Merged
das-Abroxas merged 82 commits intodevfrom Jun 29, 2023
Merged
Conversation
Currently missing: Resource authorization for path identifier.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev #87 +/- ##
==========================================
- Coverage 59.02% 56.01% -3.01%
==========================================
Files 42 44 +2
Lines 9164 10147 +983
==========================================
+ Hits 5409 5684 +275
- Misses 3755 4463 +708
☔ View full report in Codecov by Sentry. |
This function takes a relation instead of a Vec<EmittedResource> which makes it easier to emit events which concern Objects.
St4NNi
approved these changes
Jun 28, 2023
Member
St4NNi
left a comment
St4NNi
left a comment
There was a problem hiding this comment.
LGTM, way too much to properly review. Skimming over it i have not found any major flaws.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds to the ArunaServer that notifications are emitted for certain events. The condition for this is that a running AOSEventStreamer instance is registered in the configuration of the server. In order to retrieve notifications for specific resources and or their sub-resources, the public interface of an AOSEventStreamer instance must be used to create a so-called stream group.
In the first iteration, the following event notifications are delivered:
A properly functioning system for sending event notifications is also the basis for allowing system-internal services to communicate with each other asynchronously.
In addition, the
relations_db_optimisationsbranch (thanks @St4NNi) was included in this branch, which improves the internal management of path meta-information for objects. This makes it way easier to fetch the needed information for notifications and optimises database performance in the long term, which also plays a role in #75.Changelog
[event_notifications]segmentInternalEventServiceimplemented including read authorization for an arbitrary resource