Fix collection deletion including required labels#89
Merged
das-Abroxas merged 2 commits intodevfrom Jun 29, 2023
Merged
Conversation
Adds a case where an empty collection is to be deleted which has an active label ontology.
These must be removed before the collection itself, otherwise you will get a foreign key database error.
St4NNi
approved these changes
Jun 29, 2023
Member
St4NNi
left a comment
St4NNi
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR which fixes #88 .
Changes
required_labelentries associated with the collection are also deleted before the collection itself